-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(turbo-tasks): Fix building with --features=turbo-tasks/hanging_detection #75584
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@@ -140,7 +141,7 @@ impl Future for EventListener { | |||
type Output = (); | |||
|
|||
fn poll( | |||
self: std::pin::Pin<&mut Self>, | |||
self: Pin<&mut Self>, | |||
cx: &mut std::task::Context<'_>, | |||
) -> std::task::Poll<Self::Output> { | |||
let listener = unsafe { self.map_unchecked_mut(|s| &mut s.listener) }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Re: line +158]
This line depends on Pin
being in scope. We depend on Pin
both with and without hanging detection.
See this comment inline on Graphite.
Failing test suitesCommit: 57d97c9
Expand output● rewrite-headers › middleware rewrite external RSC (/hello/vercel) › should have the expected headers
● rewrite-headers › middleware rewrite external Prefetch RSC (/hello/vercel) › should have the expected headers
Read more about building and testing Next.js in contributing.md. |
57d97c9
to
f61425c
Compare
Merge activity
|
Try building with and without the feature enabled:
Closes PACK-3853