Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dev-overlay] fix: pagination focus ring was invisible #75790

Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 7, 2025

Why?

The focus outline was none, so it was unable to tell if it was focused.

Before

CleanShot.2025-02-07.at.22.02.58.mp4

After

CleanShot.2025-02-07.at.21.56.17.mp4

Closes NDX-793

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi force-pushed the 02-07-_dev-overlay_pagination_is_not_accessible_with_tab branch from dc85898 to 059a55d Compare February 7, 2025 13:01
@ijjk
Copy link
Member

ijjk commented Feb 7, 2025

Tests Passed

@devjiwonchoi devjiwonchoi force-pushed the 02-07-_dev-overlay_pagination_is_not_accessible_with_tab branch from 059a55d to fe312af Compare February 7, 2025 13:06
@devjiwonchoi devjiwonchoi changed the title [dev-overlay] pagination is not accessible with Tab [dev-overlay] fix: pagination focus ring was invisible Feb 7, 2025
@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 7, 2025 13:07
@ijjk
Copy link
Member

ijjk commented Feb 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
buildDuration 22.5s 19.2s N/A
buildDurationCached 18.1s 16.1s N/A
nodeModulesSize 392 MB 392 MB N/A
nextStartRea..uration (ms) 493ms 489ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
5306-HASH.js gzip 54.2 kB 54.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
middleware-b..fest.js gzip 674 B 673 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
app-page-exp...dev.js gzip 393 kB 393 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 896 kB 896 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_pagination_is_not_accessible_with_tab Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +2.07 kB
index.pack gzip 74.8 kB 74.4 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +2.07 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: fe312af

@devjiwonchoi devjiwonchoi merged commit f54f555 into canary Feb 7, 2025
134 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-07-_dev-overlay_pagination_is_not_accessible_with_tab branch February 7, 2025 13:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants