Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dev-overlay] HOTFIX: clicking nav escapes the overlay #75876

Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 10, 2025

Following up of #75679

Why?

Clicking the navigation escapes the overlay. It is because the navigation component is outside of the dialog component.

Before

CleanShot.2025-02-11.at.04.00.43.mp4

After

CleanShot.2025-02-11.at.04.01.17.mp4

How?

Since we already have logic to prevent closing overlay when clicked outside the component for dev indicator, add the header to this CSS selectors list as well.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 10, 2025 19:04
@devjiwonchoi devjiwonchoi requested a review from gaojude February 10, 2025 19:05
@devjiwonchoi devjiwonchoi changed the title [dev-overlay] fix: clicking nav escapes the overlay [dev-overlay] HOTFIX: clicking nav escapes the overlay Feb 10, 2025
@ijjk
Copy link
Member

ijjk commented Feb 10, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
buildDuration 18.5s 15.6s N/A
buildDurationCached 14.8s 12.5s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +2.33 kB
nextStartRea..uration (ms) 393ms 418ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
5306-HASH.js gzip 54.2 kB 54.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 539 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
middleware-b..fest.js gzip 673 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
app-page-exp...dev.js gzip 394 kB 394 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 382 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 896 kB 896 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +1.46 kB
index.pack gzip 75 kB 75.3 kB ⚠️ +229 B
Overall change 2.18 MB 2.18 MB ⚠️ +1.69 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: e90ea49

@devjiwonchoi devjiwonchoi merged commit 3fdf51c into canary Feb 10, 2025
134 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-11-_dev-overlay_fix_clicking_nav_escapes_the_overlay branch February 10, 2025 19:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants