Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove canvas test #388

Merged
merged 5 commits into from
Feb 2, 2024
Merged

chore: remove canvas test #388

merged 5 commits into from
Feb 2, 2024

Conversation

styfle
Copy link
Member

@styfle styfle commented Feb 1, 2024

This fixes an issue when a contributor (or GH Actions) runs npm install using Apple Silicon which would fail since there is no precompiled arm64 binary to download for canvas. The error looks like this:

npm ERR! node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v108-darwin-unknown-arm64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v108-darwin-unknown-arm64.tar.gz 
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for canvas@2.11.2 and node@18.19.0 (node-v108 ABI, unknown) (falling back to source compile with node-gyp) 

Since we don't have a special case for canvas and it never worked with Vercel deployments, we can remove the test.

It also doesn't decrease code coverage (in fact, I bumped code coverage thresholds just to be sure).

Related

@styfle styfle marked this pull request as ready for review February 1, 2024 20:28
@styfle styfle requested a review from ijjk as a code owner February 1, 2024 20:28
@styfle styfle requested a review from Ethan-Arrowood February 1, 2024 22:13
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@styfle styfle enabled auto-merge (squash) February 2, 2024 15:38
@styfle styfle merged commit 67d76d2 into main Feb 2, 2024
14 checks passed
@styfle styfle deleted the remove-canvas-test branch February 2, 2024 15:47
Copy link

🎉 This PR is included in version 0.26.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants