Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

feat: add option to skip signature on macos #1878

Merged
merged 5 commits into from
Mar 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/test-50-bakery-fetch/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ fetch
arch: fetch.system.hostArch,
})
.then(function (needed) {
if (process.platform === 'darwin') {
utils.spawn.sync(
'codesign',
['-fds', '-', './' + path.basename(needed)],
{ cwd: path.dirname(needed) }
);
}

right = utils.spawn.sync(
'./' + path.basename(needed),
['--expose-gc', '-e', 'if (global.gc) console.log("ok");'],
Expand Down
5 changes: 5 additions & 0 deletions test/test-50-corrupt-executable/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ const utils = require('../utils.js');
assert(!module.parent);
assert(__dirname === process.cwd());

// TODO : understand why the damage is not impacting macos build
if (process.platform === 'darwin') {
return;
}

const host = 'node' + process.version.match(/^v(\d+)/)[1];
const target = process.argv[2] || host;
const input = './test-x-index.js';
Expand Down
2 changes: 2 additions & 0 deletions test/test-50-reproducible/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const output2 = './test-output-2.exe';

utils.pkg.sync([
'--public',
'--no-signature', // the signature will make the build not reproducible
Mikescops marked this conversation as resolved.
Show resolved Hide resolved
'--no-bytecode',
'--target',
target,
Expand All @@ -30,6 +31,7 @@ utils.pkg.sync([

utils.pkg.sync([
'--public',
'--no-signature',
'--no-bytecode',
'--target',
target,
Expand Down