This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
chore: make corruption test pass on macos #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
approved these changes
Mar 20, 2023
|
Outch, the auto-merge didn't wait for the macos test to pass... |
|
@Mikescops I'm sorry for that, seems them are not set as required tests in order to pass, let's see if they end successfully |
|
@robertsLando it went well thankfully |
|
Perfect, thanks! |
pcnate
pushed a commit
to pcnate/pkg
that referenced
this pull request
Aug 15, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last PR #1878, I left a test scenario as todo concerning damaging the binary.
In fact, damaging when the code is signed had no effect as we were likely damaging the file in a non sensitive place.
To circumvent that I decided to skip the signature on macos (as other systems don't sign anyway), damage the file, then sign it manually and finally execute the test.