Skip to content

Commit

Permalink
add engine requirements to create-turbo/package.json, fix `examples…
Browse files Browse the repository at this point in the history
…/with-pnpm` (#199)

* update docs about engine versions, create npmrc

* revert docs

* add pnpm engine version in create-turbo

* fix with-turbo example package.json
  • Loading branch information
charkour authored Dec 13, 2021
1 parent 3439d75 commit 155c5c3
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 1 deletion.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,6 @@ store
!http_cache/cache/cache.go
*.log
.npmrc
!create-turbo/templates/**/*
todos.md
examples/*/*.lock
2 changes: 1 addition & 1 deletion create-turbo/__tests__/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe("create-turbo cli", () => {
beforeAll(() => {
jest.setTimeout(DEFAULT_JEST_TIMEOUT * 3);
if (!fs.existsSync(createTurbo)) {
// TODO: Consider runnuing the build here instead of throwing
// TODO: Consider running the build here instead of throwing
throw new Error(
`Cannot run Turbrepo CLI tests without building create-turbo`
);
Expand Down
1 change: 1 addition & 0 deletions create-turbo/templates/_shared_ts/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
5 changes: 5 additions & 0 deletions create-turbo/templates/_shared_ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,10 @@
"cache": false
}
}
},
"engines": {
"npm": ">=7.0.0",
"pnpm": ">=3.7.0",
"node": ">=14.0.0"
}
}
8 changes: 8 additions & 0 deletions examples/with-pnpm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
"name": "turborepo-with-pnpm",
"version": "0.0.0",
"private": true,
"scripts": {
"build": "turbo run build",
"dev": "turbo run dev --parallel",
"lint": "turbo run lint"
},
"devDependencies": {
"turbo": "latest"
},
Expand All @@ -18,6 +23,9 @@
},
"lint": {
"outputs": []
},
"dev": {
"cache": false
}
}
}
Expand Down

1 comment on commit 155c5c3

@vercel
Copy link

@vercel vercel bot commented on 155c5c3 Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please # to comment.