Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix stack trace of errors #6627

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix stack trace of errors #6627

merged 1 commit into from
Nov 29, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 28, 2023 •
edited by padmaia
Loading

Description

downcast is weird and not doing what you would expect... It picks an error from the chain of errors...

Testing Instructions

Closes PACK-2053

@sokra sokra requested a review from a team as a code owner November 28, 2023 23:12
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 11:27pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-native-web ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-svelte-web ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
examples-vite-web ⬜️ Ignored (Inspect) Nov 28, 2023 11:27pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 11:27pm

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 0553946

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 23.20ms ± 0.90ms 23.09ms ± 0.94ms -0.49%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.50ms ± 0.94ms 22.56ms ± 0.92ms +0.31%
bench_startup/Turbopack CSR/1000 modules 1090.96ms ± 5.64ms 1090.34ms ± 9.25ms -0.06%

@sokra sokra merged commit c777d4c into main Nov 29, 2023
@sokra sokra deleted the sokra/fix-stack-trace branch November 29, 2023 07:18
@sokra sokra mentioned this pull request Dec 4, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Dec 4, 2023
@sokra
fix tsconfig alias cycle (#59232)
669a48c 
### What?

fixes #59195
fixes PACK-450

### Why?

### How?

see vercel/turborepo#6687

### Turbopack Changes

* vercel/turborepo#6627 <!-- Tobias Koppers - fix
stack trace of errors -->
* vercel/turborepo#6646 <!-- OJ Kwon -
fix(turbo-tasks-fs): support unicode segment for glob -->
* vercel/turborepo#6672 <!-- OJ Kwon -
fix(ecmascript): dbg assert for the globals -->
* vercel/turborepo#6687 <!-- Tobias Koppers - fix
tsconfig alias cycle -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix stack trace of errors (vercel/turborepo#6627)
74bdd21 
### Description

`downcast` is weird and not doing what you would expect... It picks an
error from the chain of errors...

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2053
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix stack trace of errors (vercel/turborepo#6627)
9a5afba 
### Description

`downcast` is weird and not doing what you would expect... It picks an
error from the chain of errors...

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2053
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix stack trace of errors (vercel/turborepo#6627)
daeca68 
### Description

`downcast` is weird and not doing what you would expect... It picks an
error from the chain of errors...

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2053
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix stack trace of errors (vercel/turborepo#6627)
f1d9f8a 
### Description

`downcast` is weird and not doing what you would expect... It picks an
error from the chain of errors...

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2053
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @kdy1