Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: remote cache upload timeout #9491

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

chris-olszewski
Copy link
Member

Description

This was added as part of #8078 and controlled by TURBO_REMOTE_CACHE_UPLOAD_TIMEOUT. This PR just:

  • Documents that env var
  • Adds matching remoteCache.uploadTimeout option to turbo.json
  • Documents new configuration & updated schema

Testing Instructions

Added unit tests for env and turbo.json config source to make sure the setting is respected.

@turbo-orchestrator turbo-orchestrator bot added the area: docs Improvements or additions to documentation label Nov 21, 2024
@chris-olszewski chris-olszewski marked this pull request as ready for review November 21, 2024 21:49
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 9:49pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-native-web ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-svelte-web ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm
examples-vite-web ⬜️ Ignored (Inspect) Nov 21, 2024 9:49pm

@chris-olszewski chris-olszewski changed the title feat: remote cache upload timeout feat: Remote cache upload timeout Nov 21, 2024
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. And a test added, even. Legend.

@chris-olszewski chris-olszewski merged commit 0d50ffe into main Nov 22, 2024
46 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/feat_remote_cache_upload_timeout branch November 22, 2024 02:45
@EPMatt
Copy link

EPMatt commented Nov 22, 2024

Thanks for working on this! 🚀

@anthonyshew anthonyshew changed the title feat: Remote cache upload timeout feat: remote cache upload timeout Jan 28, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants