Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add best practices to Prisma ORM example #9794

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

ankur-arch
Copy link
Contributor

  1. Removed relationMode from Prisma schema:
    The relationMode setting has been removed from the schema. This setting was primarily required for databases like Planetscale when foreign key constraints were not enabled. Since most databases (including Planetscale) now support foreign keys, this configuration should no longer be necessary.

  2. Ensure latest Prisma version on installation:
    The starter now ensures that the latest version of Prisma is installed during setup. This avoids potential compatibility issues and ensures users have access to the newest features and fixes.

  3. Custom outputs directory for Prisma:
    Prisma files are now generated in a custom outputs directory. This change prevents conflicts across different package managers (e.g., npm, yarn, pnpm) and improves the reliability of the setup.

  4. Added .env file setup instructions:
    Clear instructions have been added to guide users in creating .env files for both the database package and the app. This ensures proper configuration of environment variables, which makes sure the app starts up properly.

  5. Refined README with step-by-step instructions:
    The README has been updated with detailed, step-by-step instructions to simplify the setup process. This includes guidance on installing dependencies, configuring the database, and running the project.

@ankur-arch ankur-arch requested a review from a team as a code owner January 24, 2025 18:04
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Jan 24, 2025
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:26pm

Copy link

vercel bot commented Jan 24, 2025

@ankur-arch is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jan 24, 2025

Allow CI Workflow Run

  • approve CI run for commit: 9232427

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

@ijjk
Copy link
Member

ijjk commented Jan 24, 2025

Allow CI Workflow Run

  • approve CI run for commit: 9232427

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants