Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(turborepo-wax): remove lockfile #9817

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Jan 27, 2025

Description

the same reason as for #9805, but for turborepo-wax. the package update fully removes winapi from lockfile. also cargo updated many packages for unknown reason (I've run cargo update -p winapi-util)

as asked in review lockfile is deleted

Testing Instructions

@ognevny ognevny requested a review from a team as a code owner January 27, 2025 18:14
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Jan 27, 2025
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:42pm

Copy link

vercel bot commented Jan 27, 2025

@ognevny is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jan 27, 2025

Allow CI Workflow Run

  • approve CI run for commit: 56e31be

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe this lockfile actually gets used since turborepo-wax is a member of the Cargo workspace and should use the same crate versions as the root Cargo.lock.

Could you delete this lockfile instead of updating it?

@ognevny
Copy link
Contributor Author

ognevny commented Jan 29, 2025

done

@chris-olszewski chris-olszewski merged commit ee97a3d into vercel:main Jan 29, 2025
40 checks passed
@ognevny ognevny deleted the wax-update-winapi-util branch January 29, 2025 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants