Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(@turbo/repository): silence noop lint #9835

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

chris-olszewski
Copy link
Member

Description

The recent Rust version bump started yielding these errors locally and on CI:

Screenshot 2025-01-28 at 4 54 50 PM

This is due to the #[napi] proc macro expanding to include a reference to a noop feature. To silence this lint we forward this feature to napi-derive: src.

Testing Instructions

cargo clippy should now produce no warnings

@chris-olszewski chris-olszewski marked this pull request as ready for review January 28, 2025 21:55
@chris-olszewski chris-olszewski requested a review from a team as a code owner January 28, 2025 21:55
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:55pm

@chris-olszewski chris-olszewski merged commit b96cf3e into main Jan 29, 2025
41 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_noop_lints branch January 29, 2025 00:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants