Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: use bunchee instead of tsup #9850

Merged
merged 4 commits into from
Feb 3, 2025
Merged

chore: use bunchee instead of tsup #9850

merged 4 commits into from
Feb 3, 2025

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Jan 29, 2025

Description

bunchee is an incredible bundler that automatically handles a bunch of the complexities of setting up Node.js packages. We want to encourage its usage so using it in the kitchen-sink example!

@anthonyshew anthonyshew requested a review from a team as a code owner January 29, 2025 22:43
@turbo-orchestrator turbo-orchestrator bot added the area: examples Improvements or additions to examples label Jan 29, 2025
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:31pm

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure to regen the lockfile with the correct pnpm version

@@ -1,4 +1,4 @@
lockfileVersion: '6.0'
lockfileVersion: '9.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pnpm version bump

@anthonyshew anthonyshew merged commit 55b2663 into main Feb 3, 2025
32 checks passed
@anthonyshew anthonyshew deleted the shew-4ae14 branch February 3, 2025 23:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants