Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(release): allow for overriding npm dist tag #9899

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

chris-olszewski
Copy link
Member

Description

Npm requires all published versions to have a dist tag. If we want to backport a fix we don't want to release this under the latest or canary tag. Instead we should release it under a v${SPECIFIC_MINOR} tag if we want to cut another patch under an old version (or v${SPECIFIC_MAJOR} for a minor release for a previous major)

This updates what we write to version.txt which is what gets used for our NPM publish.

Testing Instructions

prepatch release without an override
prepatch release with an override

@chris-olszewski chris-olszewski marked this pull request as ready for review February 4, 2025 20:45
@chris-olszewski chris-olszewski requested a review from a team as a code owner February 4, 2025 20:45
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:45pm

@chris-olszewski chris-olszewski enabled auto-merge (squash) February 4, 2025 20:54
@chris-olszewski chris-olszewski merged commit b0bb0af into main Feb 4, 2025
49 of 50 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/release_custom_tag branch February 4, 2025 20:58
chris-olszewski added a commit that referenced this pull request Feb 4, 2025
### Description

Npm requires all published versions to have a dist tag. If we want to
backport a fix we don't want to release this under the `latest` or
`canary` tag. Instead we should release it under a `v${SPECIFIC_MINOR}`
tag if we want to cut another patch under an old version (or
`v${SPECIFIC_MAJOR}` for a minor release for a previous major)

This updates what we write to `version.txt` which is what gets used for
our [NPM
publish](https://github.com/vercel/turborepo/blob/main/cli/Makefile#L2).

### Testing Instructions

[`prepatch` release without an
override](https://github.com/vercel/turborepo/actions/runs/13144407776/job/36679014437#step:5:12)
[`prepatch` release with an
override](https://github.com/vercel/turborepo/actions/runs/13144412891/job/36679032662#step:5:12)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants