chore(release): remove goreleaser #9905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
8de401e to
b596867
Compare
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
b596867 to
ee40557
Compare
tknickman
approved these changes
Feb 6, 2025
| import path from "node:path"; | ||
| import type { SupportedArch, HumanArch, Platform } from "./types"; | ||
|
|
||
| export const archToHuman: Record<SupportedArch, HumanArch> = { |
|
|
||
| for (const platform of platforms) { | ||
| console.log(`Processing platform: ${platform.os}-${platform.arch}`); | ||
| // eslint-disable-next-line no-await-in-loop -- We trade of slightly faster releases with more legible logging |
chris-olszewski
added a commit
that referenced
this pull request
Feb 6, 2025
This reverts commit 61425f4.
chris-olszewski
added a commit
that referenced
this pull request
Feb 6, 2025
Reverts #9905 Something up with the actual publish step
tknickman
pushed a commit
that referenced
this pull request
Feb 7, 2025
### Description Finally remove `goreleaser` after Go left the codebase a year ago. This does almost exactly what we were doing with `goreleaser` except we now base the native releases off of `version.txt` contents like every other package and not Git tags. I highly recommend reading each commit especially the first one as I mark up the `goreleaser` flow we were using explaining what exactly it did. **Updates from #9905** Include `LICENSE` in the native package distributions Create a tarball containing a directory that contains our package. Closer reading of the [npm docs](https://docs.npmjs.com/cli/v8/commands/npm-publish) make it clear this is what it expects: > A package is interpreted the same way as other commands: a) a folder containing a program described by a `package.json` file b) a gzipped tarball containing (a) We had `wrap_in_directory: true` in our [goreleaser](https://github.com/vercel/turborepo/blob/main/cli/combined-shim.yml#L45) workflow which did this for us. ### Testing Instructions [Latest dry run](https://github.com/vercel/turborepo/actions/runs/13183590746) The dry run got up to the [publishing step](https://github.com/vercel/turborepo/actions/runs/13169658592/job/36758329441#step:10:218)! All of the `tar.gz` files look correct: [logs](https://github.com/vercel/turborepo/actions/runs/13169658592/job/36758329441#step:10:298) Running locally, the contents of `tar.gz` looks to be correct: ``` [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo/cli $ tar tf dist/darwin-x64-2.4.1-canary.0.tar.gz turbo-darwin-x64/ turbo-darwin-x64/LICENSE turbo-darwin-x64/README.md turbo-darwin-x64/bin/ turbo-darwin-x64/package.json turbo-darwin-x64/bin/turbo ``` What hasn't been tested is the actual `npm publish` call, but I am fairly certain that will work as it's a very similar shell command to the one used in `goreleaser`
chris-olszewski
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Third try is the charm. See #9905 and #9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
chris-olszewski
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Third try is the charm. See #9905 and #9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description Third try is the charm. See vercel#9905 and vercel#9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally remove
goreleaserafter Go left the codebase a year ago. This does almost exactly what we were doing withgoreleaserexcept we now base the native releases off ofversion.txtcontents like every other package and not Git tags.I highly recommend reading each commit especially the first one as I mark up the
goreleaserflow we were using explaining what exactly it did.Testing Instructions
The dry run got up to the publishing step! All of the
tar.gzfiles look correct: logsRunning locally, the contents of
tar.gzlooks to be correct:What hasn't been tested is the actual
npm publishcall, but I am fairly certain that will work as it's a very similar shell command to the one used ingoreleaser