fix: check-types in kitchen-sink example #9952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Asupkay
changed the title
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description The kitchen-sink example currently has its check types command set up as "typecheck": "turbo run typecheck" however none of its packages or apps have it set up that way instead utilizing check-types. This causes the following error where none of the type checking jobs run:  This pull request changes the root package.json's check types command to check-types so that all the packages and apps correctly run type checking. This also matches other examples such as basic and with-tailwind. ### Testing Instructions To test open up the examples/kitchen-sink folder and run yarn check-types you will see the type checking jobs successfully run. 
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The kitchen-sink example currently has its check types command set up as "typecheck": "turbo run typecheck" however none of its packages or apps have it set up that way instead utilizing check-types. This causes the following error where none of the type checking jobs run:
This pull request changes the root package.json's check types command to check-types so that all the packages and apps correctly run type checking. This also matches other examples such as basic and with-tailwind.
Testing Instructions
To test open up the examples/kitchen-sink folder and run yarn check-types you will see the type checking jobs successfully run.
