chore: add check-types to root package.json if available #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Asupkay
changed the title
anthonyshew
approved these changes
Feb 14, 2025
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description There were a couple examples (basic, with-svelte) that have turbo tasks for type checking, but do not have them in the root package.json. There are other examples like (with-kitchen-sink, with-tailwind) that do include the type checking in the root package.json so this PR standardizes it across the board by adding it to the examples that are missing it. This change would be especially good for the basic package.json so beginners can easily run/find the task. ### Testing Instructions Open up examples and run `pnpm type-check`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a couple examples (basic, with-svelte) that have turbo tasks for type checking, but do not have them in the root package.json. There are other examples like (with-kitchen-sink, with-tailwind) that do include the type checking in the root package.json so this PR standardizes it across the board by adding it to the examples that are missing it. This change would be especially good for the basic package.json so beginners can easily run/find the task.
Testing Instructions
Open up examples and run
pnpm type-check