Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: package name in with-changesets release job #9971

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

Asupkay
Copy link
Contributor

@Asupkay Asupkay commented Feb 14, 2025

Description

Currently the release job points to the docs package. This is incorrect as the package is actually called @acme/docs causing the following error:

Screenshot 2025-02-14 at 11 15 42 AM

This pull request changes filter name to @acme/docs fixing the job.

Screenshot 2025-02-14 at 11 30 45 AM

This pull request also updates the documentation to reflect the actual package name.

Testing Instructions

Navigate to the with-changesets example and run pnpm release

@Asupkay Asupkay requested a review from a team as a code owner February 14, 2025 16:33
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Feb 14, 2025
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:05pm

Copy link

vercel bot commented Feb 14, 2025

@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chris-olszewski chris-olszewski enabled auto-merge (squash) February 14, 2025 17:06
@chris-olszewski chris-olszewski merged commit 70aff12 into vercel:main Feb 14, 2025
30 checks passed
joshnuss pushed a commit to joshnuss/turborepo that referenced this pull request Feb 15, 2025
### Description

Currently the release job points to the `docs` package. This is
incorrect as the package is actually called `@acme/docs` causing the
following error:

![Screenshot 2025-02-14 at 11 15
42 AM](https://github.com/user-attachments/assets/bbc759a5-9901-4749-8f58-663fa7a222eb)

This pull request changes filter name to `@acme/docs` fixing the job.

![Screenshot 2025-02-14 at 11 30
45 AM](https://github.com/user-attachments/assets/375dc309-a0cd-4d11-9cc1-23a70ee93d24)

This pull request also updates the documentation to reflect the actual
package name.

### Testing Instructions

Navigate to the `with-changesets` example and run `pnpm release`

---------

Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants