fix: incorrect AuthAccessCallback and AuthCallback (#374)

https://github.com/verdaccio/verdaccio/blob/master/src/lib/auth.ts#L264 https://github.com/verdaccio/verdaccio/blob/master/src/lib/auth.ts#L114
verdaccio · Jul 17, 2020 · 97538f8 · 97538f8
1 parent 769fed7
commit 97538f8
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/core/types/index.d.ts b/core/types/index.d.ts
@@ -496,8 +496,21 @@ declare module '@verdaccio/types' {
     tag?: string;
   }
 
-  type AuthAccessCallback = (error: string | null, access: boolean) => void;
-  type AuthCallback = (error: string | null, groups: string[] | false) => void;
+  // FIXME: error should be export type `VerdaccioError = HttpError & { code: number };` instead of AuthError
+  // but this type is on @verdaccio/commons-api and cannot be used here yet (I don't know why)
+  interface HttpError extends Error {
+    status: number;
+    statusCode: number;
+    expose: boolean;
+    headers?: {
+      [key: string]: string;
+    };
+    [key: string]: any;
+  }
+
+  type AuthError = HttpError & { code: number };
+  type AuthAccessCallback = (error: AuthError | null, access: boolean) => void;
+  type AuthCallback = (error: AuthError | null, groups: string[] | false) => void;
 
   interface IPluginAuth<T> extends IPlugin<T> {
     authenticate(user: string, password: string, cb: AuthCallback): void;