Fix incorrect AuthAccessCallback and AuthCallback #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 9.x #374 +/- ##
======================================
Coverage ? 87.87%
======================================
Files ? 5
Lines ? 132
Branches ? 29
======================================
Hits ? 116
Misses ? 8
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
juanpicado
reviewed
Jul 10, 2020
| type AuthAccessCallback = (error: string | null, access: boolean) => void; | ||
| type AuthCallback = (error: string | null, groups: string[] | false) => void; | ||
| // FIXME: error should be export type `VerdaccioError = HttpError & { code: number };` instead of AuthError | ||
| // but this type is on @verdaccio/commons-api and cannot be used here yet (I don't know why) |
There was a problem hiding this comment.
Yeah, that's something I regret now. This types and also commons api will be part of the 5.x so we won't have this issue anymore eventually.
juanpicado
reviewed
Jul 10, 2020
frimuchkov
force-pushed
the
patch-1
branch
2 times, most recently
from
376f25e to
aaa048a
Compare
|
Great job @frimuchkov !! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/verdaccio/verdaccio/blob/master/src/lib/auth.ts#L264
https://github.com/verdaccio/verdaccio/blob/master/src/lib/auth.ts#L114
Type: bug
Scope: typings