tests: add secp256k1 Point validity and de/encoding test vectors #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
commented
Oct 10, 2024
pmerkleplant
requested changes
Oct 11, 2024
pmerkleplant
approved these changes
Oct 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #23.
It adds the tests vectors for point validity and de/encoding and allows to test:
muladdIsOnCurvepointFromEncodedpointFromCompressedEncodedThe addition of those tests allowed to catch a bug:
isOnCurvewas missing a check on coordinate that needs to be inferior toP