-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rust examples: Improve rooms registry logic #1146
base: v3
Are you sure you want to change the base?
Conversation
Thanks, I'll have to look at it carefully later |
Thanks @nazar-pc I am looking into the linting issue. So that you know, this is just 1 of many PRs I will be creating. My main goal is to decouple the |
These examples are not designed to be end-user applications even remotely, there is quite a lot more involved in production application. They are just a trivial showcase how to use the library and how to have a few more things around it. Supporting more frameworks is really not the goal here and decoupling will likely require more abstractions that will make code harder to understand, not easier. |
Agreed. I plan to keep existing features as is.
Not really. Personally, it was initially difficult to understand until I saw the boundary between the participant connection and the WebSocket connection. I think explicitly showing that boundary will simplify it a bit. I don't foresee a lot of abstractions besides a By the way, it seems the CI failure is environment-related (Something with the Rust version). |
|
This change removes the redundant logic when getting or creating a room.
d27e4e2
to
dc7bb7e
Compare
As per above discussion, can we close this PR? |
I still need to look into this, but as postponing, will try to review this week |
This change removes the redundant logic when
getting or creating a room.