Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Detect devices #14

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Detect devices #14

wants to merge 10 commits into from

Conversation

Eneris
Copy link
Contributor

@Eneris Eneris commented Jan 31, 2018

Live device local media switch

Device strategy

  • New device is set as active and old is backuped
  • When device is removed, old settings is recovered or default is set

@Eneris
Copy link
Contributor Author

Eneris commented Jan 31, 2018

This PR should be considered after first one (contains commits from previous one)

@ibc
Copy link
Member

ibc commented Feb 1, 2018

It looks ok, but I see an empty line in the device selectors. It's not another option with empty value (in fact, it's a <span> rather than a <div> as real device lines):
screen shot 2018-02-01 at 22 46 56

Other than that, it looks nice :)

@Eneris
Copy link
Contributor Author

Eneris commented Feb 2, 2018

Thanks - it was "empty" options for default value but i see that's not needed with that form module

@ibc
Copy link
Member

ibc commented Feb 15, 2018

Sorry for the delay, we are very busy with other stuff. Let's check next week and merge it. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants