Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: use shims instead of direct operations on PATH #256

Merged
merged 9 commits into from
May 11, 2024

Conversation

aooohan
Copy link
Member

@aooohan aooohan commented May 9, 2024

fix #253
fix #84
fix #235
fix version-fox/vfox-golang#9

Instead of modifying the PATH directly, this change uses the fixed path $VFOX_HOME/shims and $VFOX_SHELL_TMEP/shims instead.

Currently, the way to generate shim is very violent, later we need to ask plugins to tell vfox what bins need to be generated shim. see #191 (comment)

@aooohan aooohan added this to the 0.5.0 milestone May 9, 2024
@aooohan aooohan requested review from bytemain, jan-bar and Chance-fyi May 9, 2024 09:20
@aooohan
Copy link
Member Author

aooohan commented May 9, 2024

image

@aooohan
Copy link
Member Author

aooohan commented May 9, 2024

image

@bytemain bytemain changed the title refactor: Use shims instead of direct operations on PATH. refactor: use shims instead of direct operations on PATH May 9, 2024
@aooohan aooohan marked this pull request as draft May 10, 2024 01:41
@aooohan
Copy link
Member Author

aooohan commented May 10, 2024

There's a problem on Windows, so change this to a draft.

@jan-bar
Copy link
Contributor

jan-bar commented May 10, 2024

There's a problem on Windows, so change this to a draft.

As I expected the directory to be the link instead of the executable file, many tools' executable programs will depend on the directory they are in.

Just like https://github.com/Schniz/fnm

@aooohan
Copy link
Member Author

aooohan commented May 10, 2024

As I expected the directory to be the link instead of the executable file, many tools' executable programs will depend on the directory they are in.

Yes. It's not that big of a problem, we can just implement the program exactly as mentioned in #84.

@jan-bar
Copy link
Contributor

jan-bar commented May 10, 2024

Yes. It's not that big of a problem, we can just implement the program exactly as mentioned in #84.

I like the soft link directory solution very much. I have used several version management tools using this method and it works well. I look forward to this implementation.

@aooohan
Copy link
Member Author

aooohan commented May 10, 2024

image

The problem on Windows has been solved, and the original plan is still used.

@aooohan aooohan marked this pull request as ready for review May 10, 2024 05:58
@aooohan aooohan merged commit a6370f4 into main May 11, 2024
3 checks passed
@aooohan aooohan deleted the refactor/shims branch May 11, 2024 01:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants