Always return a 415 if the content type is mismatching, also if its v…

…alue is empty (#2659) * Always return a 415 if the content type is mismatching, also if its value isempty * Update RouterTest to expect 415 for missing content type
vert-x3 · Oct 18, 2024 · b677460 · b677460
1 parent d48a6f6
commit b677460
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/vertx-web/src/main/java/io/vertx/ext/web/impl/RouteState.java b/vertx-web/src/main/java/io/vertx/ext/web/impl/RouteState.java
@@ -1096,11 +1096,7 @@ public int matches(RoutingContextImplBase context, String mountPoint, boolean fa
       MIMEHeader contentType = context.parsedHeaders().contentType();
       MIMEHeader consumal = contentType.findMatchedBy(consumes);
       if (consumal == null && !(contentType.rawValue().isEmpty() && emptyBodyPermittedWithConsumes)) {
-        if (contentType.rawValue().isEmpty()) {
-          return 400;
-        } else {
-          return 415;
-        }
+        return 415;
       }
     }
     if (!isEmpty(produces)) {

diff --git a/vertx-web/src/test/java/io/vertx/ext/web/RouterTest.java b/vertx-web/src/test/java/io/vertx/ext/web/RouterTest.java
@@ -1168,7 +1168,7 @@ public void testConsumesCTParamsIgnored() throws Exception {
   @Test
   public void testConsumesNoContentType() throws Exception {
     router.route().consumes("text/html").handler(rc -> rc.response().end());
-    testRequest(HttpMethod.GET, "/foo", HttpResponseStatus.BAD_REQUEST);
+    testRequest(HttpMethod.GET, "/foo", HttpResponseStatus.UNSUPPORTED_MEDIA_TYPE);
   }
 
   @Test