-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reduce heavy atomic operations on RoutingContextImplBase #2603
Comments
@franz1981 sorry for the delayed response. These atomic ops have been removed in #2545 and backported to 4.x in #2546 Vert.x 4.5.2 should be free of them. |
I can still see them in https://github.com/vert-x3/vertx-web/blob/4.x/vertx-web/src/main/java/io/vertx/ext/web/impl/RoutingContextImplBase.java#L157-L158 These are using atomic volatile set(s) in the hotpaths and incrementAndGet which can cost hundreds of times more than normal non atomic operations: are really required? or they could be relaxed? |
@tsegismont PTAL |
Which PR? |
There's no PR, but this comment at #2603 (comment) In #2603 (comment) it seems the atomics are not there anymore but the atomic operations are still there... |
Thanks for the heads-up, yes I can see that now. I'll look into it |
I see that 0cd7eca from @tsegismont has introduced updaters, but I still don't understand why is using such heavy weight atomic operations there.
Given that is a pretty hot path for quarkus, it would be great to use different ones.
Sending a PR soon, for evaluation
The text was updated successfully, but these errors were encountered: