[2678] Send multiple headers for url-encoded and multipart-form bodies #2679
+50
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia1243
force-pushed
the
several-header-values
branch
from
8e985f2 to
f4dd014
Compare
ilia1243
commented
Nov 12, 2024
Comment on lines
+448
to
+451
| for (String headerName : requestHeaders.names()) { | ||
| headers.remove(headerName); | ||
| } | ||
| headers.addAll(requestHeaders); |
There was a problem hiding this comment.
Actually, I do not quite understand why headers are copied twice. See
Without the second copying all tests are also passed. Check test commit ilia1243@f470308
Though I see some activity with this code
I did not remove this part, because do not see the whole picture. Please comment if this can be removed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Multiple headers are not sent with url-encoded and multipart-form bodies.
Solution:
Change resolution of headers in
HttpContext#handleCreateRequest(). Do not useMultiMap#get()to copy headers anymore. Instead, copy the entries from the original MultiMap usingMultiMap#addAll(MultiMap).Fixes #2678