Check that turnstile was loaded before calling remove during onDestroy #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Great library!
Noticed a console error:
Cannot read properties of undefined (reading 'remove')
Which is caused by this method in
src/lib/ngx-turnstile.component.ts
:We do a lot of lazy loading and generally don't load many modules in our root component.
When the user logs in and our # modal gets destroyed (which contains this widget), the
onDestroy
method is called which subsequently callswindow.turnstile.remove
.The problem in our case is that turnstile hasn't actually been loaded yet, so this pull request adds a check to make sure the widget id exists (which seems to indicate that the callback has fired) before calling
window.turnstile.remove
:Happy to make any changes.