Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add tag function #41

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Add tag function #41

merged 5 commits into from
Nov 29, 2023

Conversation

alejouribesanchez
Copy link
Collaborator

  1. Update README.md
  2. Add add_tag function to put tag on an existing document
  3. Add test of add_tag function
  4. Update .gitignore to ignore idea files from PyCharm
  5. Update User-Agent version

@alejouribesanchez
Add tag function
d26dd9b 
Update README.md
Add  add_tag function to put tag on an existing document
Add test of add_tag function
Update .gitignore to ignore idea files from PyCharm
Update User-Agent version
@alejouribesanchez
Update test_tags.py
11d1ea6
manycoding
manycoding reviewed Nov 29, 2023
View reviewed changes
manycoding
manycoding reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@manycoding manycoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, pls add test_tags to test_client instead as it's notation of pytest to exactly follow original code structure

@manycoding manycoding merged commit f76bba0 into master Nov 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@manycoding manycoding manycoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejouribesanchez @manycoding