Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Check Files Key Exists in Generator #59

Merged
merged 5 commits into from
Sep 4, 2020
Merged

Check Files Key Exists in Generator #59

merged 5 commits into from
Sep 4, 2020

Conversation

devstein
Copy link
Collaborator

@devstein devstein commented Sep 4, 2020 •
edited
Loading

Description

  • Returns a helpful error message if the files key is not defined
  • Github now installs kustomize in their linux image, so updated CI to uninstall it

Closes #58

@devstein devstein self-assigned this Sep 4, 2020
@devstein devstein added the please code review Code review needed label Sep 4, 2020
@devstein devstein merged commit 3544d3d into master Sep 4, 2020
@devstein devstein deleted the devstein/validate-files-key branch September 4, 2020 03:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jay-bhambhani jay-bhambhani Awaiting requested review from jay-bhambhani

@jpugliesi jpugliesi Awaiting requested review from jpugliesi

Assignees

@devstein devstein

Labels
please code review Code review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misspelling 'files' causes segfault
1 participant
@devstein