RSDK-9862 Add ListTunnels to robot API #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Mar 3, 2025
| repeated Tunnel tunnels = 1; | ||
| } | ||
|
|
||
| message Tunnel { |
There was a problem hiding this comment.
Tunnel is an exact duplicate of TrafficTunnelEndpoint from the app proto. I should have put TrafficTunnelEndpoint in the common proto instead of in the app proto (I don't think I can import from app proto here without weird issues,) but I was dumb and lacked foresight. I can move TrafficTunnelEndpoint to common without much trouble, but it will be a breaking change that will require admin approval (Steve, I'm assuming.) Let me know what you think.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.