Skip to content

Update cloud action to allow platform specific builds #3377

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Sep 2, 2024

@michaellee1019 Did we ever end up implementing platform specific builds? I noticed some commented out docs for this.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Sep 2, 2024
@viambot
Copy link
Member

viambot commented Sep 2, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3377

@michaellee1019
Copy link
Member

Thanks for reaching out. Its currently not supported. The meta.json schema that the CLI reads is in https://github.com/viamrobotics/rdk/blob/main/cli/module_registry.go#L63. We have discussed making platform specific build fields but it hasn't been implemented yet. For now developers can accomplish this by having platform checks within build scripts. For example: https://github.com/michaellee1019/prusa-connect-camera-server/blob/main/build.sh#L4

@npentrel
Copy link
Collaborator Author

npentrel commented Sep 5, 2024

ok, thanks

@npentrel npentrel marked this pull request as draft September 5, 2024 15:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants