fix: SSR bug with File constructor

victorgarciaesgi · Feb 11, 2025 · cfc4fa0 · cfc4fa0
1 parent b56b096
commit cfc4fa0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/nuxt/test/fixtures/pages/index.vue b/packages/nuxt/test/fixtures/pages/index.vue
@@ -66,6 +66,7 @@
                   <label class="inline-flex items-center">
                     <input
                       v-model="r$.$value.acceptTC"
+                      data-testid="acceptTC-checkbox"
                       type="checkbox"
                       class="rounded border-gray-300 text-indigo-600 shadow-sm focus:border-indigo-300 focus:ring focus:ring-indigo-200 focus:ring-opacity-50 focus:ring-offset-0"
                     />
@@ -106,6 +107,7 @@ interface Form {
   eventType?: string;
   details?: string;
   acceptTC?: boolean;
+  eventFile: File;
 }
 
 const { r$ } = useRegle({ fullName: 'Hello' } as Form, {
@@ -129,6 +131,7 @@ const { r$ } = useRegle({ fullName: 'Hello' } as Form, {
     $autoDirty: false,
     required: withMessage(and(required, checked), 'You must accept the terms and conditions'),
   },
+  eventFile: { required },
 });
 
 async function submit() {

diff --git a/packages/nuxt/test/nuxt.spec.ts b/packages/nuxt/test/nuxt.spec.ts
@@ -12,5 +12,9 @@ describe('Nuxt SSR', async () => {
 
   it('renders the index page', async () => {
     await expectNoClientErrors('/');
+
+    const page = await createPage('/');
+
+    expect(await page.getByTestId('acceptTC-checkbox').isVisible()).toBe(true);
   });
 });
diff --git a/packages/shared/utils/isEmpty.ts b/packages/shared/utils/isEmpty.ts
@@ -19,9 +19,9 @@ export function isEmpty(
   if (value instanceof Date) {
     // invalid date won't pass
     return isNaN(value.getTime());
-  } else if (value instanceof File) {
+  } else if (value.constructor.name == 'File' || value.constructor.name == 'FileList') {
     // empty files won't pass
-    return value.size > 0;
+    return (value as File).size > 0;
   } else if (Array.isArray(value)) {
     if (considerEmptyArrayInvalid) {
       return value.length === 0;