fix for #5292 - push to filterSubtitleTracks output if kind is captio…

…ns (#5297) * fix for #5292 - push to filterSubtitleTracks output if kind is captions * adding "captions" to all subtitle-track-controller tests
video-dev · Mar 17, 2023 · 4029b6d · 4029b6d
1 parent d097760
commit 4029b6d
Show file tree

Hide file tree

Showing 2 changed files with 298 additions and 282 deletions.
diff --git a/src/controller/subtitle-track-controller.ts b/src/controller/subtitle-track-controller.ts
@@ -425,7 +425,10 @@ function filterSubtitleTracks(textTrackList: TextTrackList): TextTrack[] {
   for (let i = 0; i < textTrackList.length; i++) {
     const track = textTrackList[i];
     // Edge adds a track without a label; we don't want to use it
-    if (track.kind === 'subtitles' && track.label) {
+    if (
+      (track.kind === 'subtitles' || track.kind === 'captions') &&
+      track.label
+    ) {
       tracks.push(textTrackList[i]);
     }
   }