Remove npm view "json" arg so that 16.17 does not throw on release
#4890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for next version: npm/cli#4724
Yep this was intentional so that builds could be rerun if a stage after publish failed. Otherwise given GitHub requires reruns to happen from the start you’d never be able to get a pipeline green if a later stage failed. It looks like now given it is actually returning json we could decode it and just return false if that error is exactly |
|
Actually safer to return true only if there’s no error. Would be good to see what the output actually is for exists and not exists now |
|
I opened another approach here which just hits the api directly: #4892 Should be a bit more robust than the npm cli 🤞 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into trouble with npm 16.17 publishing v1.2.2:
https://github.com/video-dev/hls.js/runs/8280226435?check_suite_focus=true#step:7:1 (ended up running the scripts locally to publish).
I seems to be related to this issue npm/cli#4724 so I'm hoping that removing the JSON arg will prevent publishing to npm from failing.
Even though publishing failed, the build step did not. Does this happen for interim (canaray) builds too? Should we change the exit code to address this?