Prioritize MP4 demux probe over MPEG-TS #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Prioritize MP4 demux probe over MPEG-TS.
Why is this Pull Request needed?
I found MP4 segments containing 2 TS sync bytes (0x47) exactly one TS packet apart (188 bytes). They're not at the start of the stream but since we allow for some scanning of segment bytes this could make HLS.js treat mp4 segments as TS segment resulting in playback failure.
HLS.js should start with the more robust mp4 probe that looks for a moov atom before looking for TS packets.
Resolves issues:
Checklist