Parse TARGETDURATION as a decimal-integer assigned a minimum value of 1 #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Parse TARGETDURATION as a decimal-integer assigned a minimum value of 1.
Why is this Pull Request needed?
TARGETDURATION is defined as an upper bound on the duration of all Media Segments in the Playlist. HLS.js already only matches the decimal-integer portion of this tags value here (
TARGETDURATION|VERSION): *(\d+)/).If an Media Playlist provides a sub-second value, HLS.js should use a value of 1 to avoid any errors in handling live playlist reload (#4464).
Are there any points in the code the reviewer needs to double check?
computeReloadIntervalalready uses the last segment duration when shorter than target duration and near live edge.Resolves issues:
Follow up on #4464
Checklist