Live reload level switch and error handling improvements #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maintain reload pace after level switch - Only define deliveryDirectives when when blocking reload is available (correct error handling) - Retry on status 0 when navigator.onLine is false
5 tasks
littlespex
approved these changes
Mar 20, 2023
|
Quick test with 3 ABR variants seems ok for me with canBlockReload |
5 tasks
robwalch
added a commit
that referenced
this pull request
Aug 31, 2023
3 tasks
robwalch
added a commit
that referenced
this pull request
Aug 31, 2023
(cherry picked from commit 5c8d086)
robwalch
added a commit
that referenced
this pull request
Sep 1, 2023
Closed
robwalch
added a commit
that referenced
this pull request
Sep 1, 2023
JackPu
reviewed
Sep 11, 2024
| @@ -61,5 +61,8 @@ export function shouldRetry( | |||
|
|
|||
| export function retryForHttpStatus(httpStatus: number | undefined) { | |||
| // Do not retry on status 4xx, status 0 (CORS error), or undefined (decrypt/gap/parse error) | |||
| return !!httpStatus && (httpStatus < 400 || httpStatus > 499); | |||
| return ( | |||
| (httpStatus === 0 && navigator.onLine === false) || | |||
There was a problem hiding this comment.
cc @robwalch I recent meet this issue. I don't get the point. Are we going to retry under user's good network? I means
(httpStatus === 0 && navigator.onLine)There was a problem hiding this comment.
It means retry later when network is disabled or completely unavailable.
A status of 0 where online equals true is typically a CORS error and should not be retried.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
navigator.onLineis false (this policy is not extended to audio and subtitle track media playlists)Why is this Pull Request needed?
On level switch the reload interval was being added to the already scheduled time for next reload, which could skip reloads after level switch.
Related issues:
#5282
#5306
Checklist