Fix for SourceBuffer full error handling #5332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Manage appendBuffer SourceBuffer full errors correctly when audio bitrate is higher than video..
Why is this Pull Request needed?
When the audio bitrate is higher than the video bitrate, SourceBuffer full errors can occur on the audio buffer as the audio-stream-controller tries to keep up with the video buffer length.
The audio-stream-controller was going past
maxMaxBufferLength
when the video buffer exceeded that length prior to its value being reduced after the first buffer full error. Further more, the max length was not being reduced more than the current buffer length on the second error at which point the entire buffer was flushed. The entire buffer should only be flushed when the buffer that errored is starved (to remove back and forward buffer not used for playback).Resolves issues:
Fixes #5328