Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Relax TTFB timeout on manifest request #5364

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Relax TTFB timeout on manifest request #5364

merged 2 commits into from
Apr 4, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Mar 31, 2023 •
edited
Loading

This PR will...

  • Update API.md to include LoadPolicy details and legacy loader setting deprecation notices
  • Relax TTFB timeout on manifest request
  • Add support for LoadPolicy maxTimeToFirstByteMs of Infinity and similarly ignore value of 0

Why is this Pull Request needed?

Demonstrates how to setup and allows for a single timeout for requests and reduces the number of timeouts created in the critical path.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch
Relax TTFB timeout on manifest request
089ed9b 
(Add support for LoadPolicy `maxTimeToFirstByteMs` of Infinity and similarly ignore value of 0)
@robwalch robwalch added this to the 1.4.0 milestone Mar 31, 2023
robwalch
robwalch commented Apr 1, 2023
View reviewed changes
src/config.ts Show resolved Hide resolved
@robwalch robwalch merged commit c5134d8 into master Apr 4, 2023
@robwalch robwalch deleted the feature/relax-manifest-ttfb-timeout branch April 4, 2023 18:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@robwalch