Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve support of unknown CODECS #6620

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 7, 2024

This PR will...

  • Support unknown codec as video or audio with passing isTypeSupported checks
  • Use multivariant playlist CODECS when mp4 parsed codec is incomplete
  • Add getMediaDecodingInfo to public API (undocumented) and fix issues with video and audio only input
  • Add codecs-helper to fill in AV1 codec string missing parameters required by MediaCapabilities decodingInfo checks

Why is this Pull Request needed?

Adds support for playback of audio and video codecs not indexed in utils/codecs or not parsed completely from mp4 init segment so long as a supported CODECS value is provided.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Aug 7, 2024
@robwalch robwalch marked this pull request as draft August 7, 2024 21:45
@robwalch robwalch requested a review from itsjamie August 13, 2024 19:17
@robwalch robwalch force-pushed the feature/unknown-codec-support branch from 59222d4 to f073588 Compare August 15, 2024 19:28
@robwalch robwalch force-pushed the feature/interstitials branch from e88a6a9 to 8490088 Compare September 9, 2024 22:28
@robwalch robwalch force-pushed the feature/unknown-codec-support branch from f073588 to 622102c Compare September 17, 2024 20:31
@robwalch robwalch force-pushed the feature/interstitials branch from df287da to 52cc78e Compare October 3, 2024 18:53
Base automatically changed from feature/interstitials to master October 3, 2024 22:19
@robwalch robwalch force-pushed the feature/unknown-codec-support branch from 622102c to df8519e Compare October 3, 2024 22:49
…checks

Add `getMediaDecodingInfo` to public API (undocumented) and fix issues with video and audio only input
Add codecs-helper to fill in AV1 codec string missing parameters required by MediaCapabilities decodingInfo checks
Use multivariant playlist CODECS when mp4 parsed codec is incomplete
@robwalch robwalch force-pushed the feature/unknown-codec-support branch from df8519e to d86e431 Compare October 3, 2024 22:52
@robwalch robwalch marked this pull request as ready for review October 3, 2024 22:54
@robwalch robwalch merged commit ed32b5b into master Oct 4, 2024
16 checks passed
@robwalch robwalch deleted the feature/unknown-codec-support branch October 4, 2024 23:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant