Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support more key system error detail #6807

Merged

Conversation

JackPu
Copy link
Contributor

@JackPu JackPu commented Oct 25, 2024

This PR will...

We will trigger more DRM-related errors to help the app collect that information.

Why is this Pull Request needed?

Even though we covered most devices and browsers. But there are still some devices that can not run it in an expected way. And they are not easy to debug with real ones. So we want to support more detailed error information to trigger for us to report.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@JackPu JackPu changed the title feat: support more key system error deatil feat: support more key system error detail Oct 25, 2024
@robwalch robwalch added this to the 1.6.0 milestone Oct 25, 2024
@JackPu JackPu force-pushed the jackpu/trigger_more_exception_detail_in_EME branch from 5c7f1a8 to 3cb4d8b Compare October 30, 2024 06:02
@JackPu
Copy link
Contributor Author

JackPu commented Nov 12, 2024

@robwalch Hi, do I need to add some unit tests for this? Or do you have your own ideas about the implementation?

Copy link
Collaborator

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robwalch Hi, do I need to add some unit tests for this? Or do you have your own ideas about the implementation?

Take a look at tests/unit/controller/eme-controller.ts. I don't know if we have mocks for producing and cover similar errors so it's OK if you don't add new tests for these non-fatal errors.

You need to fix the build (https://github.com/video-dev/hls.js/actions/runs/11626288545/job/32377670037?pr=6807) before we can merge. Running npm run sanity-check will run sub-task npm run docs which will add the missing API changes to "api-extractor/report/hls.js.api.md" you're changing with this PR (new ErrorDetails enums).

@JackPu
Copy link
Contributor Author

JackPu commented Nov 13, 2024

Thanks a lot. I will update it. I don't see any reply with the PR. I am not sure if I need to continue with it.

@JackPu JackPu requested a review from robwalch November 13, 2024 08:20
@robwalch robwalch merged commit a878ad3 into video-dev:master Nov 13, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants