Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix loading of audio media options with the same URI as the current level #6887

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Dec 3, 2024

This PR will...

Only load audio via the stream-controller (main playlist / active level) when the alternate audio rendition has the same URL.

Why is this Pull Request needed?

The stream-controller was not loading audio for audio-only streams when there were alternate audio options. It assumed that the main variant was inactive or represented by another alternate. However, if the current alternate has a (redundant) URL matching that of the main variant, instead of opting to omit the URL attribute, that alternate should not handled by the the audio-track and audio-stream-controllers.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #6859
Resolves #6783 (Fixed with #6785 but regressed with #6845)

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…evel

Resolves #6859
Resolves #6783 (Fixed with #6785 but regressed with #6845)
@robwalch robwalch added this to the 1.6.0 milestone Dec 3, 2024
@robwalch robwalch merged commit da67d31 into master Dec 3, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/audio-only-rendition-url-matches-variant branch December 3, 2024 23:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant