Maintain startup event order with autoStartLoad #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd audioTrack getter results on MANIFEST_LOADING Resolves #6891
robwalch
force-pushed
the
bugfix/track-and-level-getters-autostartload
branch
from
472ebac to
0b8c3c3
Compare
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Maintain startup event order using autoStartLoad for expected level and audioTrack getter results on MANIFEST_LOADING
Why is this Pull Request needed?
Moving the
startLoad()call evoked whenautoStartLoadistruein MANIFEST_LOADING to after MANIFEST_LOADING caused loadLevel and hls.audioTracks to not be populated in app callback to the MANIFEST_LOADING event - because level switching and associated media selection is not performed until loading is started.Fixes a regression in dev in apps that expect these getters to be populated rather that using events associated with track updates and level selection (caused by #6879).
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Resolves #6891
Checklist