Use TextTrackCue "enter" event to improve Interstitial playback timing #6900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
TextTrackCue "enter" events provide more precision for Interstitial timing than HTMLMediaElement "timeupdate" events.
Are there any points in the code the reviewer needs to double check?
An "enter" event listener is added to TextTrackCues created for interstitial date range asset-list and asset-url attributes. When dispatched, a new hls.js
EVENT_CUE_ENTER
event is triggered. The interstitial-controller usesEVENT_CUE_ENTER
to run its "timeupdate" handler at a more precise start time.The logic to advance the program is unchanged and still depends on the HTMLMediaElement
currentTime
.Resolves issues:
Checklist