Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace non-null assertions in xhr-loader and gate evoking of loader callbacks #6942

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jan 4, 2025

This PR will...

Replace non-null assertions in xhr-loader and gate evoking of loader callbacks

Why is this Pull Request needed?

To close #6359 and avoid exceptions if any in unknown execution contexts.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Jan 4, 2025
@robwalch robwalch mentioned this pull request Jan 4, 2025
3 tasks
@robwalch robwalch merged commit e346300 into master Jan 6, 2025
16 checks passed
@robwalch robwalch deleted the task/xhr-loader-replace-non-null-assertions branch January 6, 2025 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant