Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix live duration override by interstitials #6991

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Feb 4, 2025

This PR will...

Ignore non-finite MediaSource duration overrides.

Do not set duration to Infinity in getDurationAndRange as this can throw when SourceBuffers are updating.

Why is this Pull Request needed?

Prevents Interstitial asset players from resetting duration on transferred MediaSource when the schedule duration is Infinity for a live primary asset and liveDurationInfinity is false.

Duration is already set in updateMediaSource between blocking operations and should never be set in getDurationAndRange.

Are there any points in the code the reviewer needs to double check?

Only applies to live playback with Interstitials with default liveDurationInfinity of false (set to true to workaround this issue).

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…al asset players from resetting duration on transferred MediaSource)

(cherry picked from commit 12f3672bc8b08e3eb15dda67afd6c2725932540e)
@robwalch robwalch added this to the 1.6.0 milestone Feb 4, 2025
@robwalch robwalch linked an issue Feb 4, 2025 that may be closed by this pull request
5 tasks
@robwalch robwalch merged commit bb27c21 into master Feb 4, 2025
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/live-duration-interstitials branch February 4, 2025 16:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to seek forward when interstitial started
1 participant