Fix live duration override by interstitials #6991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Ignore non-finite MediaSource duration overrides.
Do not set duration to Infinity in
getDurationAndRange
as this can throw when SourceBuffers are updating.Why is this Pull Request needed?
Prevents Interstitial asset players from resetting duration on transferred MediaSource when the schedule duration is
Infinity
for a live primary asset andliveDurationInfinity
is false.Duration is already set in
updateMediaSource
between blocking operations and should never be set ingetDurationAndRange
.Are there any points in the code the reviewer needs to double check?
Only applies to live playback with Interstitials with default
liveDurationInfinity
offalse
(set totrue
to workaround this issue).Resolves issues:
Checklist