Make Fragment.stats enumerable #6999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app functionality depends on it)
robwalch
added
Regression
robwalch
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Make Fragment.stats enumerable.
Why is this Pull Request needed?
Changing
statsto a getter (#6811) made it non-enumerable. As a resultsstatsare not copied by the spread operator orObject.assign. The demo app depends on this to display fragment loading progress.Are there any points in the code the reviewer needs to double check?
Fragment.stats were changed in favor of lazy instantiation (lower memory usage at playlist parse).
Using ES5 defineProperty after class instantiation expects es6>es5 transpiling. This should have no effect if running the ESM modules (need to verify).
Resolves issues:
Checklist