change import paths from NYTimes to video-dev #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Initially I didn't want to do this to avoid a breaking change for people importing video-transocding-api as a library, but it's probably only used as a library by some internal projects at the NYT, so this is fine.
Angry users will let us know if we're wrong 😬
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hope with this PR is that a user will be able to require a v1 version of video-transcoding-api using
github.com/video-devinstead ofgithub.heygears.com/NYTimes. I don't know if this is a good idea or something worth doing.