Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Add getVideoPlaybackQuality API #225

Merged
merged 4 commits into from
Apr 27, 2017

Conversation

gesinger
Copy link
Contributor

@gesinger gesinger commented Apr 6, 2017

No description provided.

@mjneil
Copy link
Contributor

mjneil commented Apr 11, 2017

Does flash have a notion of corruptedVideoFrames?

Also what about the creationTime property? Is the plan to have the VideoPlaybackQuality plugin handle that property?

@gesinger
Copy link
Contributor Author

I couldn't find anything for corrupted frames. As for the creationTime property, since W3C specifications wanted a DOMHighResTimeStamp, I felt it might be safer to forego it for now.

@gesinger
Copy link
Contributor Author

After more discussion, creationTime will be added, but will be added from the JS level, since it needs to be relative to the time origin (https://w3c.github.io/hr-time/#time-origin).

@mjneil
Copy link
Contributor

mjneil commented Apr 13, 2017

LGTM

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add a line to the unreleased section of the changelog?

@zhuangs
Copy link

zhuangs commented Apr 20, 2017

Tested and LGTM!

@imbcmdth
Copy link
Member

Check on Firefox!

@gesinger
Copy link
Contributor Author

Works on Firefox 👍

@mjneil mjneil merged commit a6e4fdd into videojs:master Apr 27, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants